Conversation
4ed17f6 to
8d6dc48
Compare
|
This has more priority since ubuntu-20.04 runners will be removed next week. See the following message that we got on the recent merge to |
|
@profnandaa can you add the CODECOV_TOKEN to the repo secrets? The secret can be found here; https://app.codecov.io/github/validatorjs/validator.js/config/general and if needed some explanation on how to set a repository secret in GitHub; https://docs.codecov.com/docs/codecov-tokens#example-github-actions--official-codecov-action |
|
Sure, done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2539 +/- ##
===========================================
- Coverage 100.00% 99.96% -0.04%
===========================================
Files 110 113 +3
Lines 2510 2527 +17
Branches 633 641 +8
===========================================
+ Hits 2510 2526 +16
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'll take care of codecov in #2549 as it's unrelated to these changes |
Updates the versions used in CI. Also fixes the
npm-publishworkflow. In draft until #2538 is merged, so we can check that the upload to codecov worksChecklist